Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move CI builds from travis-ci.org to GitHub actions #268

Merged
merged 6 commits into from
Jul 27, 2021

Conversation

vlukashov
Copy link
Contributor

Description

The CI builds cover the following use cases:

  • run a full set of automated code checks for each PR (see unit-tests.yml and visual-tests.yml in .github/workflows/)
    • when a new PR is open (for any branch having these workflow .yml files)
    • when an open PR gets a new commit (including a force push)
  • do not run automated checks if the commit title includes skip ci
    The automated checks are skipped only for that one commit which has skip ci. For consequent commits that do not have skip ci the checks are executed normally.

The full set of automated tests includes both unit and visual tests:

  • Unit tests are executed with the Polymer 2 source code, and also with the Polymer 3 source code after running the P2-to-P3 conversion script.
    • The unit tests with the Polymer 3 source code are executed in a set of different browsers / platforms (via SauceLabs).
    • The unit tests with the Polymer 2 source code are executed in a few browsers running headlessly in the CI agent.
  • Visual tests are executed with the Polymer 2 source code in Chrome and Firefox (via SauceLabs).

Related to: https://github.com/vaadin/components-team-tasks/issues/586

Type of change

  • Bugfix
  • Feature
  • Internal change

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Viktor Lukashov and others added 3 commits July 5, 2021 23:58
The CI builds cover the following use cases:
 - run a full set of automated code checks for each PR (see `unit-tests.yml` and `visual-tests.yml` in `.github/workflows/`)
   - when a new PR is open (for any branch having these workflow .yml files)
   - when an open PR gets a new commit (including a force push)
 - do not run automated checks if the commit title includes `skip ci`
   The automated checks are skipped only for that one commit which has `skip ci`. For consequent commits that do not have `skip ci` the checks are executed normally.

The full set of automated tests includes both unit and visual tests:
 - Unit tests are executed with the Polymer 2 source code, and also with the Polymer 3 source code after running the P2-to-P3 conversion script.
   - The unit tests with the Polymer 3 source code are executed in a set of different browsers / platforms (via SauceLabs).
   - The unit tests with the Polymer 2 source code are executed in a few browsers running headlessly in the CI agent.
 - Visual tests are executed with the Polymer 2 source code in Chrome and Firefox (via SauceLabs).

Related to: https://github.com/vaadin/components-team-tasks/issues/586
@CLAassistant
Copy link

CLAassistant commented Jul 27, 2021

CLA assistant check
All committers have signed the CLA.

@sissbruecker sissbruecker merged commit 27cf6f5 into 2.4 Jul 27, 2021
@web-padawan web-padawan deleted the vl/move-from-travis-to-gh-actions branch July 28, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants