Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable row drag and drop while loading #2957

Merged
merged 7 commits into from
Nov 3, 2021
Merged

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented Oct 29, 2021

Fixes #2896

@tomivirkki tomivirkki marked this pull request as draft October 29, 2021 14:03
@tomivirkki tomivirkki marked this pull request as ready for review November 1, 2021 13:25
@hdamr hdamr self-requested a review November 2, 2021 11:55
Copy link
Contributor

@hdamr hdamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the map application with new changes and error was gone, I also ran the tests locally and they were passing, and they failed when the change was reverted.

Copy link
Contributor

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested with the sample application and was able to see why the error happens.
💯

@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki tomivirkki merged commit d334ed4 into master Nov 3, 2021
@tomivirkki tomivirkki deleted the dnd-filters-no-item branch November 3, 2021 11:50
@vaadin-bot
Copy link
Collaborator

Hi @tomivirkki , this commit cannot be picked to 21.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick d334ed4
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 3759 and retry the command.
error: could not apply d334ed4... fix: disable row drag and drop while loading (#2957)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS Error after dropping an item on Grid
4 participants