Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to set virtualizer items when not opened #7325

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Apr 11, 2024

Description

Fixes a regression from #7277

In vaadin-combo-box, we have a logic that clears scroller items on close:

scroller.setProperties({
items: opened ? items : [],

In the PR linked above, this behavior was broken by the items observer change.

Added a test to ensure visible items count is reset (which is a side effect of clearing items).
This seems to be the easiest way to test the change without accessing __virtualizer API.

Type of change

  • Bugfix

@web-padawan web-padawan requested a review from vursen April 11, 2024 13:54
Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-padawan web-padawan requested a review from tomivirkki April 11, 2024 14:31
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha22 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants