feat: support elements in dashboard items #7761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugur-vaadin
approved these changes
Sep 5, 2024
# Conflicts: # packages/dashboard/src/vaadin-dashboard.js # packages/dashboard/test/dashboard.test.ts
|
|
This ticket/PR has been released with Vaadin 24.6.0.beta1 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support providing element instances in
<vaadin-dashboard>items.If an
HTMLElementinstance is passed asitem.componentrenderercall for the item is skipped in favor of using the provided element as the widget.<vaadin-dashboard-section>element internally is skipped in favor of using the provided element as the section.This feature is added exclusively for the
DashboardFlow component's purposes, specifically to enableDashboardSectionto extendComponent, and thus doesn't include type definitions.Type of change
Feature