feat: add API to define Dialog position programmatically #7971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `top` and `left` properties to `<vaadin-dialog>` to allow setting the overlay position programmatically.
web-padawan
reviewed
Oct 14, 2024
An error occurred while trying to automatically change base from
fix/dialog/drag-set-top-left
to
main
October 14, 2024 15:46
web-padawan
reviewed
Oct 17, 2024
|
web-padawan
approved these changes
Oct 28, 2024
|
This ticket/PR has been released with Vaadin 24.6.0.beta1 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
topandleftproperties to<vaadin-dialog>to allow setting the overlay position programmatically.Part of #1060
Depends on #7970
Type of change