feat: allow dropping folders #8032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
commented
Oct 30, 2024
| } | ||
|
|
||
| const filePromises = Array.from(dropEvent.dataTransfer.items) | ||
| .map((item) => item.webkitGetAsEntry()) |
There was a problem hiding this comment.
At the moment webkitGetAsEntry seems to be the only API that allows retrieving a folder from a data transfer item that is supported by all browsers.
There is also getAsFileSystemHandle, but that isn't supported by FF or Safari. Then there are some mentions of other APIs in the referenced issue, none of which seem to have made it into the standard.
vursen
reviewed
Oct 30, 2024
vursen
approved these changes
Oct 30, 2024
DiegoCardoso
approved these changes
Oct 30, 2024
tomivirkki
reviewed
Oct 30, 2024
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
|
|
This ticket/PR has been released with Vaadin 24.6.0.beta1 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to drop folders into the upload component. Folders will be scanned recursively for files and any file found will be added to the file list for uploading. It's also possible to drop a combination of files and folders. Files are still filtered by the accept filter and any non-matching file will be discarded.
Just noting that this doesn't introduce any new concepts such as having folders as a separate entry in the upload component. This is just a shortcut for adding all files from a folder to the upload.
Part of #857