-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure grid has tabbable elements after it becomes visible #8102
Conversation
Quality Gate passedIssues Measures |
Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually? |
… (#8105) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
This ticket/PR has been released with Vaadin 24.6.0.alpha3 and is also targeting the upcoming stable 24.6.0 version. |
Description
Fixes #8098
When the grid is initially hidden,
_headerFocusable
is set toundefined
since there is no first visible row.Added the call to
_resetKeyboardNavigation()
on appear and a test to ensure focus gets moved properly.This makes the grid Tab navigation work in
Popover
and manually attachedDialog
.Type of change