Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure grid has tabbable elements after it becomes visible #8102

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes #8098

When the grid is initially hidden, _headerFocusable is set to undefined since there is no first visible row.
Added the call to _resetKeyboardNavigation() on appear and a test to ensure focus gets moved properly.

This makes the grid Tab navigation work in Popover and manually attached Dialog.

Type of change

  • Bugfix

Copy link

sonarcloud bot commented Nov 7, 2024

@web-padawan web-padawan removed the request for review from sissbruecker November 7, 2024 13:51
@web-padawan web-padawan merged commit ecb3ecd into main Nov 7, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/grid-appear-focusable branch November 7, 2024 13:52
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick ecb3ecd
error: could not apply ecb3ecd... fix: ensure grid has tabbable elements after it becomes visible (#8102)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.alpha3 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover does not handle keyboard focus of Grid
3 participants