fix: set input value font weight property on input container #8141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
web-padawan
force-pushed
the
fix/input-value-font-weight
branch
from
aac2dcb
to
78e03eb
Compare
sissbruecker
approved these changes
Nov 18, 2024
|
Yes, the only thing is that incorrect default (400) was changed to the one actually used. So maybe it's ok to consider this a regular fix. |
web-padawan
changed the title
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
web-padawan
added a commit
that referenced
this pull request
Nov 18, 2024
web-padawan
added a commit
that referenced
this pull request
Nov 18, 2024
|
This ticket/PR has been released with Vaadin 24.6.0.alpha4 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7957
Moved the font-weight custom CSS property to the correct file. Also changed it to
500for backwards compatibility in order to not break screenshots (currently used400has never been working properly).Marked as a behavior altering fix, though I think we can still backport it at least to 24.5 to make the property work.
Type of change