refactor: reduce item renderer calls in combo box #8173
Conversation
There was a problem hiding this comment.
#7044 introduced a number of requestContentUpdate calls for several scenarios:
- Clear cache
- Change size
- Page loads
With that, the component now effectively runs ComboBoxMixin.requestContentUpdate three times when filtering using a data provider. Previously the method wasn't run at all and only the scroller would update.
But ComboBoxMixin.requestContentUpdate, in addition to updating the scroller, also runs renderers for all items again. So that results in three additional renderer calls for each item, for each filter change, when using a data provider.
Before the change
after.mov
After the change
before.mov
It looks like we can optimize that to only run requestContentUpdate on the scroller instead. I guess the question is then if there is any logic in data provider mixin that could cause an item's data to be updated, instead of the whole item reference, in which case this optimization would probably break something.
sissbruecker
changed the title
|
|
This ticket/PR has been released with Vaadin 24.6.0.beta1 and is also targeting the upcoming stable 24.6.0 version. |
Replaces calls to
ComboBoxMixin.requestContentUpdatewith callingrequestContentUpdateon the scroller, which avoids additional item renderer calls after the scroller has already updated.