Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Bulgaria holidays to holiday groups and categories #1351

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Migrate Bulgaria holidays to holiday groups and categories, add uk localization.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency upgrade (version update)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@KJhellico KJhellico requested a review from arkid15r June 30, 2023 19:17
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling 6e4c197 on KJhellico:ref-bulgaria into c240d08 on dr-prodigy:beta.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇧🇬 LGTM

The "Ден на народните будители" uk translation isn't ideal but I couldn't quickly come up w/ something better.

@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label Jul 5, 2023
@KJhellico
Copy link
Collaborator Author

Yes, I couldn't find a better translation 🤷‍♂️

@KJhellico KJhellico merged commit c35442e into vacanza:beta Jul 6, 2023
@KJhellico KJhellico deleted the ref-bulgaria branch July 6, 2023 15:07
@KJhellico KJhellico removed the ready for beta Ready to merge on beta branch label Jul 6, 2023
@arkid15r arkid15r mentioned this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants