Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Morocco holidays: add fr localization #1375

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Morocco holidays fr localization.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@coveralls
Copy link

coveralls commented Jul 16, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling 89ee42c on KJhellico:loc-morocco into 15c9857 on dr-prodigy:beta.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇲🇦 ✅

@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label Jul 19, 2023
@arkid15r arkid15r changed the title Morocco holidays fr localization Update Morocco holidays: add fr localization Jul 19, 2023
@arkid15r arkid15r merged commit 7a3509f into vacanza:beta Jul 20, 2023
19 checks passed
@arkid15r arkid15r removed the ready for beta Ready to merge on beta branch label Jul 20, 2023
@KJhellico KJhellico deleted the loc-morocco branch July 20, 2023 17:32
@KJhellico KJhellico mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants