Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some URLs after moving to an organization #1387

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Update some URLs after moving to an organization #1387

merged 4 commits into from
Jul 24, 2023

Conversation

arkid15r
Copy link
Collaborator

Proposed change

Make partial updates to some URLs after moving to an organization.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@arkid15r arkid15r requested a review from KJhellico July 21, 2023 17:39
@coveralls
Copy link

coveralls commented Jul 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5646927910

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.975%
Totals Coverage Status
Change from base Build 5616707875: 0.0%
Covered Lines: 8963
Relevant Lines: 8964
💛 - Coveralls

abh31000
abh31000 reviewed Jul 22, 2023
View reviewed changes
CONTRIBUTING.rst Outdated
.. _prs: https://github.com/dr-prodigy/python-holidays/pulls
.. _`beta branch`: https://github.com/dr-prodigy/python-holidays/tree/beta
.. _prs: https://github.com/vacanza/python-holidays/pulls
.. _`beta branch`: https://github.com/vacanza/python-holidays/tree/beta
.. |contributors| image:: https://img.shields.io/github/contributors/dr-prodigy/python-holidays
:target: https://www.github.com/dr-prodigy/python-holidays
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't this link to https://github.com/vacanza/python-holidays/graphs/contributors ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Included 👍

KJhellico
KJhellico reviewed Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arkid15r arkid15r merged commit 32fe8da into vacanza:beta Jul 24, 2023
19 checks passed
@arkid15r arkid15r deleted the update-repository-links branch July 24, 2023 23:07
@KJhellico KJhellico mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KJhellico KJhellico KJhellico left review comments

@abh31000 abh31000 abh31000 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arkid15r @coveralls @KJhellico @abh31000