Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Indonesia holidays, add l10n support #1389

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Update Indonesia holidays:

  • add l10n support (en_US, id, uk)
  • add historical holidays

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@KJhellico KJhellico requested a review from arkid15r July 23, 2023 11:56
@coveralls
Copy link

coveralls commented Jul 23, 2023

Pull Request Test Coverage Report for Build 5636261466

Details

  • 53 of 53 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.975%

Totals Coverage Status
Change from base Build 5616707875: 0.0%
Covered Lines: 8991
Relevant Lines: 8992

💛 - Coveralls

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇮🇩 LGTM

self.assertTrue(
set(range(1946, 2050)).difference(set(range(1968, 2003))).issubset(years_found)
)
self.assertEqual(0, len(years_found.intersection(set(range(1968, 2003)))))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and after

Suggested change
self.assertEqual(0, len(years_found.intersection(set(range(1968, 2003)))))
self.assertFalse(set(range(1968, 2003)).intersection(years_found))

@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label Jul 27, 2023
@arkid15r arkid15r merged commit 9e7997f into vacanza:beta Jul 28, 2023
22 checks passed
@arkid15r arkid15r removed the ready for beta Ready to merge on beta branch label Jul 28, 2023
@KJhellico KJhellico deleted the ref-indonesia-loc branch July 29, 2023 12:37
@KJhellico KJhellico mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants