Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HolidayBase::_add_holiday_* family methods [n-p] #1407

Merged

Conversation

arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Aug 2, 2023

Proposed change

This PR continues #1368. Update countries starting w/ n-p.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@arkid15r arkid15r requested a review from KJhellico August 2, 2023 17:15
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5741813406

  • 127 of 127 (100.0%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 99.871%

Totals Coverage Status
Change from base Build 5697996975: 0.04%
Covered Lines: 9108
Relevant Lines: 9114

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label Aug 3, 2023
@arkid15r arkid15r merged commit 6caf7d0 into vacanza:beta Aug 4, 2023
22 checks passed
@arkid15r arkid15r deleted the extend-add-holiday-with-syntactic-sugar-n-p branch August 4, 2023 16:23
@arkid15r arkid15r removed the ready for beta Ready to merge on beta branch label Aug 4, 2023
@KJhellico KJhellico mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants