Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Saudi Arabia holidays: fix Eid al-Fitr and Eid al-Adha observance #1414

Merged
merged 4 commits into from
Aug 15, 2023

Conversation

KJhellico
Copy link
Collaborator

@KJhellico KJhellico commented Aug 4, 2023

Proposed change

Update Saudi Arabia:

  • fix observed holidays for Eid al-Fitr and Eid al-Adha.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@KJhellico KJhellico requested a review from arkid15r August 4, 2023 17:28
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

holidays/countries/saudi_arabia.py Outdated Show resolved Hide resolved
holidays/countries/saudi_arabia.py Outdated Show resolved Hide resolved
@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label Aug 10, 2023
@coveralls
Copy link

coveralls commented Aug 12, 2023

Pull Request Test Coverage Report for Build 5840833997

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 100.0%

Totals Coverage Status
Change from base Build 5764796537: 0.1%
Covered Lines: 9112
Relevant Lines: 9112

💛 - Coveralls

@arkid15r arkid15r changed the title Update Saudi Arabia: fix observed holidays for Eid al-Fitr and Eid al-Adha Update Saudi Arabia holidays: fix Eid al-Fitr and Eid al-Adha observance Aug 15, 2023
@arkid15r arkid15r merged commit 5b2d84e into vacanza:beta Aug 15, 2023
22 checks passed
@arkid15r arkid15r removed the ready for beta Ready to merge on beta branch label Aug 15, 2023
@KJhellico KJhellico deleted the upd-saudi-arabia branch August 15, 2023 16:31
@arkid15r arkid15r mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants