Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor HolidayBase methods #1425

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Refactor HolidayBase methods #1425

merged 4 commits into from
Aug 15, 2023

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Refactor HolidayBase::__init__() and HolidayBase::__str__() methods.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5841925093

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5788118002: 0.0%
Covered Lines: 9104
Relevant Lines: 9104
💛 - Coveralls

arkid15r
arkid15r reviewed Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

holidays/holiday_base.py Outdated Show resolved Hide resolved
@KJhellico @arkid15r
PR suggestion
c46a733 
Co-authored-by: Arkadii Yakovets <ark@cho.red>
arkid15r
arkid15r reviewed Aug 15, 2023
View reviewed changes
holidays/holiday_base.py
@@ -325,22 +325,14 @@ def __init__(
f"Category is not supported: {', '.join(unknown_categories)}."
)

name = getattr(self, "country", getattr(self, "market", None))
name: Optional[str] = getattr(self, "country", getattr(self, "market", None))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, this looks like a good candidate for start using :=

@arkid15r arkid15r merged commit 567d06a into vacanza:beta Aug 15, 2023
22 checks passed
@KJhellico KJhellico deleted the ref-holiday-base branch August 15, 2023 19:21
@arkid15r arkid15r mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KJhellico @coveralls @arkid15r