-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Slovenia holidays: add 2023 Solidarity Day #1426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions here :)
[SL] add test case, switch to `special_holiday`
Pull Request Test Coverage Report for Build 5854580446
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the contribution and prompt comments addressing @kanobi! I've just merged it into beta (don't worry about the failed tests, it's unrelated to your PR) |
Proposed change
This PR adds the "Solidarity Day" public holiday for Slovenia for August 14th 2023.
https://en.wikipedia.org/wiki/Public_holidays_in_Slovenia
Type of change
Checklist
beta
branch of the repositorymake pre-commit
make test
,make tox
(we strongly encourage adding tests to your code)