Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slovenia holidays: add 2023 Solidarity Day #1426

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

kanobi
Copy link
Contributor

@kanobi kanobi commented Aug 13, 2023

Proposed change

This PR adds the "Solidarity Day" public holiday for Slovenia for August 14th 2023.
https://en.wikipedia.org/wiki/Public_holidays_in_Slovenia

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@kanobi kanobi changed the title Add si solidarity day Add SI Solidarity Day Aug 13, 2023
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions here :)

CHANGES Outdated Show resolved Hide resolved
holidays/countries/slovenia.py Outdated Show resolved Hide resolved
@kanobi kanobi changed the base branch from master to beta August 14, 2023 10:19
[SL] add test case, switch to `special_holiday`
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5854580446

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 5788118002: 0.0%
Covered Lines: 9111
Relevant Lines: 9111

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

holidays/countries/slovenia.py Outdated Show resolved Hide resolved
@arkid15r arkid15r changed the title Add SI Solidarity Day Update Slovenia holidays: add 2023 Solidarity Day Aug 15, 2023
@arkid15r arkid15r merged commit 025f4bf into vacanza:beta Aug 15, 2023
22 checks passed
@arkid15r
Copy link
Collaborator

Thanks for the contribution and prompt comments addressing @kanobi!

I've just merged it into beta (don't worry about the failed tests, it's unrelated to your PR)

@arkid15r arkid15r mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants