Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Algeria holidays: add fr localization #1467

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

abh31000
Copy link
Contributor

Proposed change

Algeria fr localization.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6160989794

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6148690766: 0.0%
Covered Lines: 9191
Relevant Lines: 9191

💛 - Coveralls

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks neat!

A few items to revisit:

holidays/locale/fr/LC_MESSAGES/DZ.po Outdated Show resolved Hide resolved
holidays/countries/algeria.py Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/DZ.po Outdated Show resolved Hide resolved
holidays/locale/fr/LC_MESSAGES/DZ.po Show resolved Hide resolved
@arkid15r arkid15r added this pull request to the merge queue Sep 15, 2023
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this. The fr l10n inconsistency ticket -- #1471

Merged via the queue into vacanza:beta with commit 5807a79 Sep 15, 2023
22 checks passed
@KJhellico KJhellico mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants