-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update China holidays add non-statutory holidays support, l10n, optional half-day holidays #1491
Conversation
Pull Request Test Coverage Report for Build 6427501304
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great PR -- a lot of work towards CN holidays improvement! It feels like a whole new country support has been added 👍
Here are some suggestions on how we could make the code better:
Let's deal with this first and take care of the coverage after that. |
Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Co-authored-by: Arkadii Yakovets <ark@cho.red>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed change
Add non-statutory (but part of official public holiday allotment) observed holidays, as well as
HALF-DAY
category and general l10n support (en_US
,th
,zh_CN
,zh_TW
).The following implementation is cross-checked with official sources from 2001-2023, with earlier date implementation based on the relevant section of the 1949 and 1999 revisions of the Chinese Holiday Act.
Happy Mid-Autumn Festival! 🌔 🥮
Closes #1475 .
Type of change
Checklist
beta
branch of the repositorymake pre-commit
command generates no changesmake test
,make tox
(we strongly encourage adding tests to your code)