Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coding observed_rule for Bahamas #1527

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Remove hard-coding observed_rule for Bahamas #1527

merged 1 commit into from
Oct 25, 2023

Conversation

PPsyrius
Copy link
Collaborator

Proposed change

Somehow, the new standard adopted in #1521 wasn't implemented for the Bahamas (we missed it somehow during the PR review) - this PR fixes this.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6622045634

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.978%
Totals Coverage Status
Change from base Build 6620987603: 0.0%
Covered Lines: 10069
Relevant Lines: 10069
💛 - Coveralls

KJhellico
KJhellico approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

arkid15r
arkid15r approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇧🇸 LGTM

@arkid15r arkid15r added this pull request to the merge queue Oct 25, 2023
Merged via the queue into vacanza:beta with commit 77b0377 Oct 25, 2023
27 checks passed
@PPsyrius PPsyrius deleted the BS_no_more_observed_rule_hardcoding branch October 25, 2023 03:01
@arkid15r arkid15r mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r approved these changes

@KJhellico KJhellico KJhellico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PPsyrius @coveralls @arkid15r @KJhellico