Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test coverage to 100% #1573

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Conversation

arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Nov 25, 2023

Proposed change

A couple of changes in order to make the coverage 100% again.
I've fixed two cases by changing elif to else condition and also added non-observed holidays test for one more case. The snapshot generator generates no diff so I hope it should be fine.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

Copy link

sonarcloud bot commented Nov 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6986751556

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 100.0%

Totals Coverage Status
Change from base Build 6985976736: 0.02%
Covered Lines: 10286
Relevant Lines: 10286

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And I'm working on refactoring these holidays as substituted. :)

@arkid15r arkid15r added this pull request to the merge queue Nov 26, 2023
Merged via the queue into vacanza:beta with commit ff1b55c Nov 26, 2023
27 checks passed
@arkid15r arkid15r deleted the update-coverage branch November 26, 2023 16:15
@arkid15r arkid15r mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants