-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge substituted holidays with special holidays #1580
Conversation
Pull Request Test Coverage Report for Build 7064413923
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better with less code (as we discussed).
Some concerns to address:
167cf4f
to
0f4ef88
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed change
Merge substituted holidays with special holidays (into single
special_holidays
).Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally