-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address numpy int argument conversion issue #1782
Conversation
As long as |
Pull Request Test Coverage Report for Build 8978758502Details
💛 - Coveralls |
@pytest.mark.skipif( | ||
platform().startswith("Windows") | ||
and python_implementation().startswith("PyPy") | ||
and python_version().startswith("3.10"), | ||
reason='Avoid "make: *** [Makefile:63: test] Error 5" for pypy3.10 on Windows', | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not there yet :)
https://github.com/KJhellico/python-holidays/actions/runs/8928197300/job/24523240416
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Proposed change
Resolves #1779
This change fixes
years
numpy int incompatibility issue. In order to test it properly we'll neednumpy
package installed in the test environment. I'm still not sure if that's a great idea as it's not really 💯 PH issue. On the other hand Prophet is a huge part of our ecosystem and it'd be very nice of us to take care of the issue.FYI: there is a problem when running the new test on Windows pypy3.10 so I skipped it with
skipif
. It looks likeimport numpy
causes that. If anyone knows how to fix that please let me know.I also added pypy3.9 pypy3.10 to tox.ini env list.
@KJhellico @PPsyrius I'd like to know your opinion on this PR -- I'm open to removing the test or discarding the PR entirely based on your suggestions.
Thank you!
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally