Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Malaysia holidays #1791

Merged
merged 3 commits into from
May 20, 2024
Merged

Update Malaysia holidays #1791

merged 3 commits into from
May 20, 2024

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Update Malaysia holidays:

  • migrate to subdivision holidays methods
  • rename subdivisions according to ISO 3166-2
  • l10n (en_US, ms_MY)
  • update tests

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9083653824

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9025569154: 0.0%
Covered Lines: 11167
Relevant Lines: 11167

💛 - Coveralls

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

holidays/countries/malaysia.py Show resolved Hide resolved
holidays/countries/malaysia.py Show resolved Hide resolved
KJhellico and others added 2 commits May 20, 2024 19:52
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 LGTM

@arkid15r arkid15r added this pull request to the merge queue May 20, 2024
Merged via the queue into vacanza:dev with commit 74fd76d May 20, 2024
29 checks passed
@arkid15r arkid15r mentioned this pull request May 20, 2024
@KJhellico KJhellico deleted the ref-malaysia branch May 21, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants