Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update observed rules: add holiday removal support #1796

Merged
merged 1 commit into from
May 17, 2024

Conversation

arkid15r
Copy link
Collaborator

Proposed change

This PR extends our ObservedRule class to support "move to None" cases. In other words it's a holiday removal (no holiday + no observance type of rule). I've got this idea while reviewing #1792, specifically from this comment. It'll be useful for making IFEU holiday calendar a bit cleaner.

Let me know your thoughts on this when you get a chance.

P.S. I did my best to avoid naming the rule ???_TO_NONDAY :)

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@arkid15r arkid15r requested a review from KJhellico as a code owner May 17, 2024 15:46
@arkid15r arkid15r requested review from PPsyrius and KJhellico and removed request for KJhellico May 17, 2024 15:47
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9130851431

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9099445825: 0.0%
Covered Lines: 11169
Relevant Lines: 11169

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! It's will be useful for some European and LATAM countries also.

@arkid15r arkid15r added this pull request to the merge queue May 17, 2024
Merged via the queue into vacanza:dev with commit c8c408d May 17, 2024
29 checks passed
@arkid15r arkid15r deleted the update-observed-rules branch May 17, 2024 16:45
This was referenced May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants