Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend HolidayBase::__setitem__ to handle names including '; ' #1858

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Jul 9, 2024

Proposed change

Handle ; in holidays names.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@arkid15r arkid15r requested a review from KJhellico as a code owner July 9, 2024 00:07
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5de8e60) to head (2fbbc1b).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1858   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          184       184           
  Lines        11194     11194           
  Branches      1765      1765           
=========================================
  Hits         11194     11194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkid15r arkid15r changed the title Fix setitem semicolon value Extend HolidayBase::__setitem__ to handle names including ; Jul 9, 2024
@arkid15r arkid15r enabled auto-merge July 9, 2024 00:17
holidays/holiday_base.py Outdated Show resolved Hide resolved
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Jul 9, 2024
Merged via the queue into vacanza:dev with commit 477c594 Jul 9, 2024
30 checks passed
@arkid15r arkid15r deleted the fix-setitem-semicolon-value branch July 9, 2024 17:04
@arkid15r arkid15r changed the title Extend HolidayBase::__setitem__ to handle names including ; Extend HolidayBase::__setitem__ to handle names including '; ' Jul 15, 2024
@arkid15r arkid15r mentioned this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants