Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs requirements: revert sphinx to v7.4.7 #1893

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Aug 1, 2024

Proposed change

Update docs requirements: revert sphinx to v7.4.7

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c2723c4) to head (16759da).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1893   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          185       185           
  Lines        11222     11222           
  Branches      1766      1766           
=========================================
  Hits         11222     11222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkid15r arkid15r enabled auto-merge August 1, 2024 16:32
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Aug 1, 2024
Merged via the queue into vacanza:dev with commit bd16a33 Aug 1, 2024
24 checks passed
@arkid15r arkid15r deleted the fix-docs-requirements branch August 1, 2024 16:45
@KJhellico KJhellico mentioned this pull request Aug 5, 2024
@arkid15r arkid15r mentioned this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants