Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cambodian holidays for 2024 #1936

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

PPsyrius
Copy link
Collaborator

Proposed change

April 16, 2024 is in fact declared as part of extended "Khmer New Year" (Sangkranta) holidays as seen in here (Web Archive Copy).

This also updates the list of years when such holiday started on APR 14 (instead of the usual APR 13) as shown on its Wikipedia page.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

sonarcloud bot commented Aug 20, 2024

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5c3250e) to head (548bbf6).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1936   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          186       186           
  Lines        11315     11316    +1     
  Branches      1789      1789           
=========================================
+ Hits         11315     11316    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkid15r arkid15r added this pull request to the merge queue Aug 20, 2024
Merged via the queue into vacanza:dev with commit 17e3780 Aug 20, 2024
28 checks passed
@PPsyrius PPsyrius deleted the update_kh_2024_songkran branch August 20, 2024 19:33
@KJhellico KJhellico mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants