Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add day for NY holidays from government decree #582

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Add day for NY holidays from government decree #582

merged 3 commits into from
Jan 18, 2022

Conversation

Enzokot
Copy link
Contributor

@Enzokot Enzokot commented Dec 31, 2021

No description provided.

@dr-prodigy dr-prodigy changed the base branch from master to beta January 4, 2022 16:17
@dr-prodigy
Copy link
Collaborator

Hi @Enzokot ,
thank you for your support.
Would you please add a specific unit test to cover your new code?
Thx!

@Enzokot
Copy link
Contributor Author

Enzokot commented Jan 4, 2022 •
edited
Loading

@dr-prodigy Hi! Sorry, my bad.

@dr-prodigy dr-prodigy added the invalid Not passing tests label Jan 15, 2022
@dr-prodigy
Copy link
Collaborator

Hi @Enzokot I ran checks on your code, but they're currently failing: would you please double-check / review?
Thx! 👍

@Enzokot
Copy link
Contributor Author

Enzokot commented Jan 15, 2022

@dr-prodigy Hi! Sorry, my bad. Done. Please, re-run the test.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1701181804

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.945%
Totals Coverage Status
Change from base Build 1631040884: 0.0%
Covered Lines: 5783
Relevant Lines: 5848
💛 - Coveralls

@dr-prodigy dr-prodigy merged commit f0c30b7 into vacanza:beta Jan 18, 2022
@dr-prodigy
Copy link
Collaborator

Hi @Enzokot,
your PR is merged in beta.. thank you very much for your support! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid Not passing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Enzokot @dr-prodigy @coveralls