[Feature] Spain: Adds 2022 holidays #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtrabanco
changed the title
gtrabanco
changed the title
dr-prodigy
added a commit
that referenced
this pull request
Jan 20, 2022
|
Fixed some small issues and merged in beta.. thx a lot! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds 2022 holidays in Spain and it provinces.
All dates over 2022 will be considered as 2022 for estimate holidays but every year around October the national holidays are published in official publication BOE and the festivities of each province in similar publication that is done by province authorities.
This adds all festivities in 2022.
Test
Deleted the test for province days later than 2022 because it is an estimation and due the explanation in the description we can not test and know which will be the days of each province always, there are some that changes every year.
Known issues
I am not able to know it and if it is happening I am not able to fix it but, I think this library is not moving Sunday festivities to Mondays as it should do so 2022 holidays that are on Mondays by this reason I have to move them manually.
Anyway it is not always true that Sunday holidays go to Monday because it is holiday anyway but not always in all provinces.