Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added all italian provinces #617

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Added all italian provinces #617

merged 2 commits into from
Feb 9, 2022

Conversation

energywave
Copy link
Contributor

I've added all italian provinces "santo patrono", wrote in comments the reference links about the dates and the list.
Implemented 100% of the tests about provinces and cities of composites provinces (like Balretta-Andria-Trani).
Edited provinces list in the readme to reflect all the provinces implemented.

@energywave
Copy link
Contributor Author

I hope to have not made mistakes as this is my first PR...

@energywave
Copy link
Contributor Author

I forgot to say that I didn't add the note in the readme.rst file about "Santo Patrono" of provinces (now called subdivisions) are only valid in "Capoluogo di provincia" and not in the rest of province territory, if not in some exceptions. Just to ensure an informed use of library by users.

@dr-prodigy dr-prodigy merged commit 1a46335 into vacanza:beta Feb 9, 2022
@energywave
Copy link
Contributor Author

@dr-prodigy can you please suggest me what's the problem with the quality assurance checks? So the next time I can do what I did not this time.

@dr-prodigy
Copy link
Collaborator

Hi @energywave
thank you for your work!
I've just merged it on beta (just a few code format fixes were required.. good job!).
Regarding README notes, I considered not to explicit this: all around the lib (and world too) there are a good number of specific caveats/not obvious behaviours, but none of them appears in the README (aiming to stay short and synthetic).
Those are usually clarified in the code with comments.
Thx again, best 👍

@energywave
Copy link
Contributor Author

Wonderful, all clear. Thank you and keep on the good work :)

@energywave energywave deleted the beta branch February 9, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants