Add coverage tests for many countries #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosfurton
changed the title
dr-prodigy
reviewed
Apr 2, 2022
There was a problem hiding this comment.
Hi @akosfurton !
While I agree on a good number of these reviews, I don't understand why there are a lot of "elif" blocks being replaced by "if".. which is maybe not functionally harmful, but surely less ideal in terms of performance..
could you please explain their reason why and/or review them?
thx!
|
PS: btw @akosfurton , relevant build tests are also failing (most probably due to some mis-formatting): could you double-check those too? |
|
Yes, will make the above changes and re-run the tests |
|
hey there @akosfurton any news on what above? |
|
At last, I applied this PR too, after some final fixes. Now available in beta, thx 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add many other country tests to fix edge cases and improve coverage
@dr-prodigy , please approve the workflows