Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fix to stop In lieu holidays being added multiple times #717

Closed
wants to merge 1 commit into from
Closed

added fix to stop In lieu holidays being added multiple times #717

wants to merge 1 commit into from

Conversation

amas01
Copy link

@amas01 amas01 commented Sep 16, 2022

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 99.577% when pulling 3ec2c1a on amas01:704-Singapore_holidays into a12b021 on dr-prodigy:beta.

@mborsetti
Copy link
Contributor

@dr-prodigy This is related to #704, where we are awaiting for your response on an architectural preference.

Incidentally, this PR does not fix all countries that are affected, namely:

  • GR
  • KR
  • MY
  • SG
  • SZ
  • ZA
  • ZW

@dr-prodigy
Copy link
Collaborator

Hi @mborsetti does what shared on #704 sort this out too? Thx!

@mborsetti
Copy link
Contributor

@dr-prodigy Based on your comments in #704, IMHO this PR should not be adopted and closed.

@dr-prodigy
Copy link
Collaborator

Okay @mborsetti , that's the confirmation I was asking for.
Closing due to what explained on #704 , thank you very much! 👍

@dr-prodigy dr-prodigy closed this Oct 23, 2022
@dr-prodigy dr-prodigy mentioned this pull request Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants