Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hong Kong holidays update #786

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Conversation

KJhellico
Copy link
Collaborator

  • holidays establishing years specified
  • historical holidays added
  • Lunar New Year and Christmas calculation fix
  • Ching Ming Festival / Easter Monday overlapping fix
  • optimizations
  • tests added

@coveralls
Copy link

coveralls commented Nov 13, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 01ec752 on KJhellico:upd-hongkong into 6f3242d on dr-prodigy:beta.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

holidays/countries/hongkong.py Outdated Show resolved Hide resolved
holidays/countries/hongkong.py Outdated Show resolved Hide resolved
holidays/countries/hongkong.py Outdated Show resolved Hide resolved
holidays/countries/hongkong.py Show resolved Hide resolved
holidays/countries/hongkong.py Show resolved Hide resolved
holidays/countries/hongkong.py Show resolved Hide resolved
holidays/countries/hongkong.py Show resolved Hide resolved
- holidays establishing years specified
- historical holidays added
- Lunar New Year and Christmas calculation fix
- Ching Ming Festival and Easter Monday overlapping fix
- optimizations
- tests added
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

holidays/countries/hongkong.py Show resolved Hide resolved
@dr-prodigy dr-prodigy merged commit 83d26fe into vacanza:beta Nov 26, 2022
@KJhellico KJhellico deleted the upd-hongkong branch November 26, 2022 16:30
@dr-prodigy dr-prodigy mentioned this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants