Refactor HolidayBase class and utils #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Optimize branching.
- Remove unneeded casting/copying.
- Add `_add_observed_holiday` method.
- Optimize methods:
- `__setattr__`
- `__keytransform__`
- `__getitem__`
- `__setitem__`
- `get_named`
- `update`
- `__repr__`
- `__str__`
- Simplify `utils.country_holidays` country/market lookup logic.
- Fix minor issues (style, grammar, punctuation).
- Clean up unused code.
|
Wow, that's a lot of good edits. 👍 I can't find any apparent faults with it, but realize that while I wrote util._islamic_to_gre to return a list, it could/should probably return a generator instead. |
|
Thanks for the review, @mborsetti!
That's a good point, done! |
|
So good work! I could not check every single row, but all looks fine to me! Thank you @arkid15r 👍 |
KJhellico
added a commit
to KJhellico/python-holidays
that referenced
this pull request
Jan 29, 2023
- fix for holidays that happen twice in a Gregorian year (primarily islamic New Year) - years range checking more strictly - utils._islamic_to_gre() refactoring from vacanza#815 (except returning value type change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify and optimize PH foundational code logic.
It covers
holiday_base.pyandutils.py. The main points are:_add_observed_holidaymethod.__setattr____keytransform____getitem____setitem__get_namedupdate__repr____str__utils.country_holidayscountry/market lookup logic.I'd like to request @dr-prodigy (obviously), @kasya, @KJhellico, @mborsetti consider reviewing it. Feel free to jump in even if you weren't tagged but have comments regarding this change.
Thank you!