Improve Thailand holidays #929

PPsyrius · 2023-02-04T09:16:37Z

A subclass of :py:class:HolidayBase representing public holidays in Thailand.
(Based on South Korean and Singaporean Implementation)

Limitations:

This is only 100% accurate for 1997-2023; any future dates are up to Royal Thai Government Gazette updates on a year-by-year basis.
Approx. date only goes as far back as 1941 (B.E. 2484) as the Thai calendar for B.E. 2483 as we only have nine months from switching New Year Date (April 1st to January 1st).
Thai Lunar Calendar Holidays only work from 1941 (B.E. 2484) onwards until 2057 (B.E. 2600) as we only have Thai year-type data for cross-checking until then
Royal Ploughing Ceremony Day is date is announced on an annual basis by the Court Astrologers, so this will need an annual update to the library here
This doesn't cover Thai regional public holidays yet, but this is for the future

References:

Based on: https://en.wikipedia.org/wiki/Public_holidays_in_Thailand
Checked with: https://www.bot.or.th/Thai/FinancialInstitutions/FIholiday/Pages/2023.aspx
For individual data sources in detail, see the in-code comment below

v.0.19

…refs, etc.

KJhellico · 2023-02-04T10:09:34Z

Great work!

KJhellico

Here is 2 critical changes (special_holidays and redundant parenthesis in Wisakha Bucha code)

holidays/countries/thailand.py

test/countries/test_thailand.py

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>

Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>

PPsyrius · 2023-02-04T11:24:37Z

@KJhellico Thank you so much for the help :)

I've fixed all the mentioned errors and applied all other suggestions; feel free to let me know if you need anything else.

KJhellico · 2023-02-04T12:35:07Z

PR should be into beta branch. So you need to rebase your changes on beta. And fix code formatting (see CONTRIBUTING.rst). And extend tests to all new cases. :)

…mes for now)

PPsyrius · 2023-02-05T08:15:06Z

@KJhellico The pre-commit checks from tox look good now, I hope :)

I'm willing to update this pull request so that the new changes would work perfectly with the i18n PoC (#827); just let me know if you plan to merge that change in first.

My other concern is the fact that ISO 3166-2:TH standards for provinces is pretty non-descriptive at best (a bit better than TIS 1099-2548 where the ISO codes were based on that has subdistrict code reuses) - so I'm thinking of using 3-letter acronyms from Royal Thai Government Announcement for Internal Indexing on 2021 (B.E. 2564) for future subdivision pull requests, if possible. Or ideally, finding ways to map both systems together so that input for either provincial code works.

test/countries/test_thailand.py

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>

holidays/countries/thailand.py

Added tests for Thailand

holidays/utils.py

Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>

KJhellico

Seems good

holidays/utils.py

- Simplified __init__ section for Thailand's, removed for _ThaiLuniSolar - Simplified _ThaiLuniSolar holiday codes - _ThaiLuniSolar's comment are now docstrings - Move all Thailand's holiday references to above limitations' section - Remove Thailand's duplicate date checks (with TODO comments instead) - Thailand's In Line comments are also moved to each holiday's header for better readability Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>

Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>

test/countries/test_thailand.py

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>

arkid15r

Looks good to me except a few minor issues.

Thanks for addressing all the comments!

holidays/utils.py

holidays/countries/thailand.py

Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>

holidays/utils.py

PPsyrius · 2023-02-10T18:26:03Z

We failed coverall tests as the two extra cases added (Atthami Bucha, End of Buddhist Lent) got no active use cases.

Should we just comment them out for now or add tests for them somewhere?

arkid15r · 2023-02-10T18:41:30Z

We failed coverall tests as the two extra cases added (Atthami Bucha, End of Buddhist Lent) got no active use cases.

Should we just comment them out for now or add tests for them somewhere?

If you're comfortable with adding those - it would be just perfect! Otherwise I'd take a look into it early next week.

I'm going to merge this PR later today.

This PR has taken a huge amount of work. Thank you @PPsyrius, @KJhellico!

PPsyrius · 2023-02-10T18:45:48Z

I'll leave the issue of test cases for those two dates in your hands then - from a quick check, while Atthami Bucha (Buddha's Cremation Day) got no public holiday among mainland SEA countries in Sri Lanka; the End of Buddhist Lend (Ok Phansa in Laos and Boun Om Touk in Cambodia`) are still celebrated, even if they're yet to be implemented in this library at this point.

TYSM for all the help :)

arkid15r and others added 4 commits January 30, 2023 13:47

Merge pull request vacanza#915 from dr-prodigy/beta

7655c6e

v.0.19

Thai Lunar Calendar added, exact start of holidays for historic use, …

cb71848

…refs, etc.

In-code comment improvements for readability

db48d5e

Add contact info in case future changes are needed

b36704b

KJhellico requested changes Feb 4, 2023

View reviewed changes

Fixed syntax error

9a764a9

PPsyrius force-pushed the thailand_improved branch from 034f734 to 9a764a9 Compare February 4, 2023 11:05

PPsyrius and others added 4 commits February 4, 2023 18:08

TH Special Holidays code improvements

c96309f

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>

TH in lieu holiday trigger refactor

3443182

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>

TH: turns out <= <= is now a thing

f2e2902

Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>

TH testcases updated

58f4a41

Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>

TH: case switch for standardizaton

88a35c6

PPsyrius requested a review from KJhellico February 4, 2023 11:30

PPsyrius changed the base branch from master to beta February 4, 2023 12:37

PPsyrius added 5 commits February 4, 2023 19:41

Merge branch 'beta' into thailand_improved

6e4d4fd

TH autoformatting from running tox

f68e1ca

TH: E266 comment block format adherence

4027ef6

TH: E501 line too long format adherence (except link and Thai date na…

61e315b

…mes for now)

TH: E501 cleanups. other final checks (for now)

81a7477

KJhellico reviewed Feb 5, 2023

View reviewed changes

test/countries/test_thailand.py Outdated Show resolved Hide resolved

TH Sort testcase date

db4cda7

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>

KJhellico reviewed Feb 5, 2023

View reviewed changes

holidays/countries/thailand.py Outdated Show resolved Hide resolved

Added tests for Thailand

7842122

KJhellico reviewed Feb 5, 2023

View reviewed changes

holidays/countries/thailand.py Outdated Show resolved Hide resolved

PPsyrius added 2 commits February 5, 2023 21:27

Merge pull request #2 from KJhellico/thailand_improved

7fb9721

Added tests for Thailand

TH fixed Visakha Bucha trigger

2a13149

KJhellico reviewed Feb 9, 2023

View reviewed changes

holidays/utils.py Outdated Show resolved Hide resolved

KJhellico reviewed Feb 9, 2023

View reviewed changes

holidays/utils.py Outdated Show resolved Hide resolved

PPsyrius and others added 2 commits February 9, 2023 23:41

TH: add_holiday --> _add_with_observed for unified wording

5235050

TH: KJhellico's suggestions

8126bd2

Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>

PPsyrius requested a review from KJhellico February 9, 2023 16:48

KJhellico approved these changes Feb 9, 2023

View reviewed changes

arkid15r reviewed Feb 9, 2023

View reviewed changes

PPsyrius and others added 2 commits February 10, 2023 14:51

TH: in-line single instance holidays

6990cd8

Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>

PPsyrius requested a review from arkid15r February 10, 2023 09:41

KJhellico reviewed Feb 10, 2023

View reviewed changes

test/countries/test_thailand.py Outdated Show resolved Hide resolved

TH: forgot to re-sort this, oof

a443bc4

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>

arkid15r reviewed Feb 10, 2023

View reviewed changes

holidays/utils.py Outdated Show resolved Hide resolved

holidays/countries/thailand.py Outdated Show resolved Hide resolved

holidays/countries/thailand.py Show resolved Hide resolved

holidays/countries/thailand.py Outdated Show resolved Hide resolved

PPsyrius and others added 2 commits February 11, 2023 01:06

TH: fixed duplicate var, other improvements

372f631

Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>

TH: clean up comments

c0902d7

arkid15r reviewed Feb 10, 2023

View reviewed changes

holidays/utils.py Outdated Show resolved Hide resolved

TH: back to @lru_cache() again

4072208

PPsyrius requested a review from arkid15r February 10, 2023 18:17

arkid15r added the ready for beta Ready to merge on beta branch label Feb 10, 2023

arkid15r changed the title ~~Thailand Calendar Improvements~~ Improve Thailand holidays Feb 10, 2023

arkid15r merged commit c32369d into vacanza:beta Feb 10, 2023

arkid15r removed the ready for beta Ready to merge on beta branch label Feb 10, 2023

PPsyrius mentioned this pull request Feb 15, 2023

Add Thailand holidays localization: en_US, th #946

Merged

PPsyrius deleted the thailand_improved branch February 16, 2023 14:31

This was referenced Feb 20, 2023

v.0.20 #967

Merged

v.0.20 #974

Merged

v.0.20 #982

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve Thailand holidays #929

Improve Thailand holidays #929

PPsyrius commented Feb 4, 2023 •

edited

Loading

KJhellico commented Feb 4, 2023

KJhellico left a comment

PPsyrius commented Feb 4, 2023

KJhellico commented Feb 4, 2023

PPsyrius commented Feb 5, 2023 •

edited

Loading

KJhellico left a comment

arkid15r left a comment

PPsyrius commented Feb 10, 2023

arkid15r commented Feb 10, 2023

PPsyrius commented Feb 10, 2023 •

edited

Loading

Improve Thailand holidays #929

Improve Thailand holidays #929

Conversation

PPsyrius commented Feb 4, 2023 • edited Loading

KJhellico commented Feb 4, 2023

KJhellico left a comment

Choose a reason for hiding this comment

PPsyrius commented Feb 4, 2023

KJhellico commented Feb 4, 2023

PPsyrius commented Feb 5, 2023 • edited Loading

KJhellico left a comment

Choose a reason for hiding this comment

arkid15r left a comment

Choose a reason for hiding this comment

PPsyrius commented Feb 10, 2023

arkid15r commented Feb 10, 2023

PPsyrius commented Feb 10, 2023 • edited Loading

PPsyrius commented Feb 4, 2023 •

edited

Loading

PPsyrius commented Feb 5, 2023 •

edited

Loading

PPsyrius commented Feb 10, 2023 •

edited

Loading