Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Thailand related changes coverage decrease #942

Merged
merged 5 commits into from
Feb 14, 2023

Conversation

arkid15r
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Feb 13, 2023

Coverage Status

Coverage: 100.0% (+0.2%) from 99.779% when pulling 81eff85 on arkid15r:fix-test-coverage into 24acdfb on dr-prodigy:beta.

@PPsyrius
Copy link
Collaborator

Thanks for the help :)

@PPsyrius
Copy link
Collaborator

@arkid15r Hi, I did add some additional test cases for other Thai Lunar Calendar holidays (Makha Bucha, Visakha Bucha, Khao Phansa) - pls check the PR in your repo :)

@arkid15r
Copy link
Collaborator Author

@arkid15r Hi, I did add some additional test cases for other Thai Lunar Calendar holidays (Makha Bucha, Visakha Bucha, Khao Phansa) - pls check the PR in your repo :)

Merged in! Thanks a lot for the additional test cases! In order to fix the coverage I had added the bare minimum only tests.

@arkid15r arkid15r merged commit 2be6a43 into vacanza:beta Feb 14, 2023
@arkid15r arkid15r deleted the fix-test-coverage branch February 14, 2023 16:53
This was referenced Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants