Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize observed holidays, part 2 #952

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Optimize observed holidays, part 2 #952

merged 2 commits into from
Feb 17, 2023

Conversation

KJhellico
Copy link
Collaborator

Angola, Eswatini, Kazakhstan, Kenya, Malawi, Singapore, South Africa

@coveralls
Copy link

coveralls commented Feb 16, 2023 •
edited
Loading

Coverage Status

Coverage: 100.0%. Remained the same when pulling 1b9fc8e on KJhellico:opt-observed-2 into f2571fa on dr-prodigy:beta.

PPsyrius
PPsyrius requested changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@PPsyrius PPsyrius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good IMO, this one can be improved though, now that we're touching them anyway.

holidays/countries/kenya.py Outdated Show resolved Hide resolved
@KJhellico @PPsyrius
fix
1b9fc8e 
Co-authored-by: PPsyrius <19505219+PPsyrius@users.noreply.github.com>
arkid15r
arkid15r reviewed Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge great-quality work! Thank you for optimizing the performance issues!

LGTM

@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label Feb 16, 2023
@arkid15r arkid15r changed the title Optimize observed holidays (part 2) Optimize observed holidays, part 2 Feb 17, 2023
@arkid15r arkid15r merged commit d267936 into vacanza:beta Feb 17, 2023
@arkid15r arkid15r added performance and removed ready for beta Ready to merge on beta branch labels Feb 17, 2023
@arkid15r
Copy link
Collaborator

Great stuff 👍👍

@KJhellico KJhellico deleted the opt-observed-2 branch February 17, 2023 16:48
This was referenced Feb 20, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r left review comments

@PPsyrius PPsyrius PPsyrius requested changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KJhellico @coveralls @arkid15r @PPsyrius