fix: valueOr and withValue utilities #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanyaprem
added a commit
to waku-org/nwaku
that referenced
this pull request
Apr 3, 2024
3 tasks
tests/testutility.nim
Outdated
Comment on lines
93
to
95
| check false | ||
| else: | ||
| counter.inc() |
There was a problem hiding this comment.
we can probably extract it to a proc inside the test and avoid the repetition
There was a problem hiding this comment.
You mean something like that?
proc testProc[T](val: Opt[T] | Option[T], counter: var int) =
val.withValue(v):
fail()
else:
counter.inc()
testProc(Opt.none(TestObj), counter)
testProc(none(TestObj), counter)If there were more than two occurrences of this test I would do it, but I don't think it really brings something in this specific case.
There was a problem hiding this comment.
Yes, the benefit is avoiding code duplication, which I believe is never desirable.
diegomrsantos
approved these changes
Apr 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1079 +/- ##
============================================
- Coverage 84.82% 84.56% -0.26%
============================================
Files 91 91
Lines 15428 15487 +59
============================================
+ Hits 13087 13097 +10
- Misses 2341 2390 +49
|
SionoiS
pushed a commit
to waku-org/nwaku
that referenced
this pull request
Apr 4, 2024
* feat: draft changes to use a storage manager for sync * chore: address comments and resolve compilation issues * chore: fixing test in progress * chore: in progress time based storage creation * fix: handle server not having storage * chore: remove unused methods * fix: import for trace logging * fix: sync exports * fix: duplicate invocation of dial due to a bug in valueOr vacp2p/nim-libp2p#1079 * chore: refactor and introduce sync session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a double call when using the
valueOr,withValueandtoOpttemplates.The issue was found by @chaitanyaprem with a double call of a custom protocol here: https://github.com/waku-org/nwaku/blob/feat--nwaku-sync/waku/waku_sync/protocol.nim#L125-L126