Hole Punching #806
Merged
Hole Punching #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomrsantos
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #806 +/- ##
============================================
+ Coverage 84.20% 84.25% +0.04%
============================================
Files 90 91 +1
Lines 15239 15311 +72
============================================
+ Hits 12832 12900 +68
- Misses 2407 2411 +4
|
diegomrsantos
force-pushed
the
hole-punching
branch
from
d8dac63 to
b8b8470
Compare
diegomrsantos
force-pushed
the
hole-punching
branch
4 times, most recently
from
869d8d2 to
e7bb48d
Compare
alrevuelta
reviewed
Nov 30, 2022
diegomrsantos
force-pushed
the
hole-punching
branch
from
ed00285 to
5bb56db
Compare
Closed
diegomrsantos
force-pushed
the
hole-punching
branch
from
52af3ed to
5331726
Compare
diegomrsantos
force-pushed
the
hole-punching
branch
from
3cdf333 to
ddb5f33
Compare
diegomrsantos
force-pushed
the
hole-punching
branch
from
ddb5f33 to
5f4745e
Compare
Menduist
previously approved these changes
Apr 14, 2023
# Conflicts: # libp2p/multiaddress.nim # libp2p/protocols/connectivity/dcutr/client.nim # libp2p/protocols/connectivity/dcutr/core.nim # libp2p/protocols/connectivity/dcutr/server.nim # tests/testdcutr.nim # tests/testnative.nim
|
@Menduist the tests have been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements end-to-end TCP hole punching, integrating the previously implemented services (Autorelay and Autonat) and protocol (DCUtr) into the Hole Punching Service.
One of the Hole Punching service's responsibilities is to detect new relayed connections and try a unilateral connection upgrade if the remote peer has public dialable addresses. Otherwise, it tries to hole punch using the DCUtr protocol.
It also required changing how local ports are chosen when dialing peers. Previously, it was always chosen by the OS according to availability. This is still done when peer reachability is unknown or public, but the listening port is used instead when the peer is unreachable.