Autonat service #814
Merged
Autonat service #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #814 +/- ##
============================================
- Coverage 83.62% 83.59% -0.03%
============================================
Files 81 82 +1
Lines 14726 14910 +184
============================================
+ Hits 12314 12464 +150
- Misses 2412 2446 +34
|
diegomrsantos
force-pushed
the
autonat-service
branch
from
5014cd6 to
5f7cbd2
Compare
alrevuelta
reviewed
Dec 7, 2022
alrevuelta
reviewed
Dec 8, 2022
3 tasks
diegomrsantos
force-pushed
the
autonat-service
branch
from
36cf4cf to
a4999bf
Compare
diegomrsantos
force-pushed
the
autonat-service
branch
from
b166ae1 to
c36fbb2
Compare
Menduist
reviewed
Dec 14, 2022
libp2p/services/autonatservice.nim
Outdated
Comment on lines
130
to
151
| method setup*(self: AutonatService, switch: Switch): Future[bool] {.async.} = | ||
| let hasBeenSettedUp = await procCall Service(self).setup(switch) | ||
| if hasBeenSettedUp: | ||
| self.newConnectedPeerHandler = proc (peerId: PeerId, event: PeerEvent): Future[void] {.async.} = | ||
| discard askPeer(self, switch, peerId) | ||
| switch.connManager.addPeerEventHandler(self.newConnectedPeerHandler, PeerEventKind.Joined) | ||
| if self.scheduleInterval.isSome(): | ||
| self.registerLoop = register(self, switch, self.scheduleInterval.get()) | ||
| return hasBeenSettedUp | ||
|
|
||
| method run*(self: AutonatService, switch: Switch) {.async, public.} = | ||
| await askConnectedPeers(self, switch) | ||
|
|
||
| method stop*(self: AutonatService, switch: Switch): Future[bool] {.async, public.} = | ||
| let hasBeenStopped = await procCall Service(self).stop(switch) | ||
| if hasBeenStopped: | ||
| if not isNil(self.registerLoop): | ||
| self.registerLoop.cancel() | ||
| self.registerLoop = nil | ||
| if not isNil(self.newConnectedPeerHandler): | ||
| switch.connManager.removePeerEventHandler(self.newConnectedPeerHandler, PeerEventKind.Joined) | ||
| return hasBeenStopped |
There was a problem hiding this comment.
This is very confusing, to refacto during the service rework
diegomrsantos
force-pushed
the
autonat-service
branch
from
e5fc20b to
bd8ec0b
Compare
Menduist
reviewed
Dec 15, 2022
Menduist
reviewed
Dec 15, 2022
Menduist
reviewed
Dec 15, 2022
Menduist
reviewed
Dec 15, 2022
Menduist
previously approved these changes
Dec 15, 2022
diegomrsantos
force-pushed
the
autonat-service
branch
from
3b6bbcb to
6d95519
Compare
Menduist
reviewed
Dec 16, 2022
Menduist
approved these changes
Dec 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a service which uses the Autonat protocol to estimate a node network reachability on the internet.