Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WAKU2-PEER-EXCHANGE: Move to draft #7

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jimstir
Copy link
Collaborator

@jimstir jimstir commented Feb 25, 2024

Move 34/WAKU2-PEER-EXCHANGE to draft.

@jimstir jimstir marked this pull request as draft February 25, 2024 00:57
@jimstir
Copy link
Collaborator Author

jimstir commented Oct 24, 2024

"We will investigate peer exchange cache sizes and refresh strategies,
and provide suggestions based on that in future versions
(draft, stable) of this document."

This statement was removed. Is there any update to this that could be added to this spec?

@jimstir jimstir marked this pull request as ready for review October 24, 2024 03:17
@jimstir jimstir requested a review from jm-clius October 24, 2024 03:18
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jm-clius
Copy link
Contributor

"We will investigate peer exchange cache sizes and refresh strategies, and provide suggestions based on that in future versions (draft, stable) of this document."

This statement was removed. Is there any update to this that could be added to this spec?

@darshankabariya added some logic for refreshing the peer exchange cache. Perhaps you can verify that the spec is up to date and add a line or two on what we do in terms of refreshing the caches?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants