This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Add WakuMetadata to TWN #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add WakuMetadata to TWN
2 tasks
jm-clius
approved these changes
Oct 4, 2023
content/docs/rfcs/64/README.md
Outdated
| inbound/outbound peer that attempts to connect supports. In any of the following cases, the node MUST trigger a disconnection: | ||
| * [WAKU-METADATA](https://rfc.vac.dev/spec/66/) dial fails. | ||
| * [WAKU-METADATA](https://rfc.vac.dev/spec/66/) reports an empty `<cluster_id>`. | ||
| * [WAKU-METADATA](https://rfc.vac.dev/spec/66/) reports different `<cluster_id>` than the local one. |
There was a problem hiding this comment.
Since for TWN cluster_id can only be 1, perhaps we can be explicit here and simply say something like:
reports
<cluster_id>different than1.
There was a problem hiding this comment.
indeed, fixed!
3b4ee7e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WakuMetadata to TWN