Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #212

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Fix tests #212

merged 5 commits into from
Sep 4, 2023

Conversation

tyshko-rostyslav
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Benchmark for af03e04

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1251.3±0.63ns 1247.8±6.93ns -0.28%
FullMerkleTree::get 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::override_range 3.1±0.00µs 3.2±0.00µs +3.23%
FullMerkleTree::set 1245.9±2.49ns 1244.2±0.77ns -0.14%
OptimalMerkleTree::compute_root 1412.1±1.69ns 1388.8±0.97ns -1.65%
OptimalMerkleTree::delete 1406.0±1.27ns 1383.3±0.94ns -1.61%
OptimalMerkleTree::get 30.0±0.02ns 29.5±0.01ns -1.67%
OptimalMerkleTree::override_range 7.0±0.01µs 7.1±0.01µs +1.43%
OptimalMerkleTree::set 1404.5±14.16ns 1388.0±3.76ns -1.17%

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Benchmark for af03e04

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.1±0.12ns 2.2±0.15ns +4.76%
Pmtree::get 540.5±25.30ns 561.8±27.79ns +3.94%
Pmtree::override_range 229.7±14.71µs 239.0±26.62µs +4.05%
Pmtree::set 79.8±4.62µs 82.4±4.06µs +3.26%
Pmtree:delete 77.9±4.85µs 80.2±4.76µs +2.95%

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Benchmark for 587eeb6

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1251.4±0.65ns 1264.9±3.86ns +1.08%
FullMerkleTree::get 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::override_range 3.1±0.00µs 3.1±0.00µs 0.00%
FullMerkleTree::set 1246.1±0.73ns 1252.5±4.48ns +0.51%
OptimalMerkleTree::compute_root 1423.6±1.09ns 1409.3±0.84ns -1.00%
OptimalMerkleTree::delete 1420.4±1.72ns 1405.8±1.32ns -1.03%
OptimalMerkleTree::get 29.1±0.01ns 29.1±0.02ns 0.00%
OptimalMerkleTree::override_range 7.0±0.01µs 7.0±0.01µs 0.00%
OptimalMerkleTree::set 1415.3±15.98ns 1396.7±1.01ns -1.31%

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Benchmark for 587eeb6

Click to view benchmark
Test Base PR %
Pmtree::compute_root 1.7±0.00ns 1.7±0.01ns 0.00%
Pmtree::get 464.3±0.28ns 464.1±0.54ns -0.04%
Pmtree::override_range 177.1±17.95µs 171.9±9.79µs -2.94%
Pmtree::set 65.9±0.32µs 67.1±0.06µs +1.82%
Pmtree:delete 66.2±0.06µs 66.2±0.05µs 0.00%

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Benchmark for fa81676

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1245.0±0.54ns 1243.5±0.65ns -0.12%
FullMerkleTree::get 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::override_range 3.1±0.00µs 3.1±0.00µs 0.00%
FullMerkleTree::set 1244.2±0.92ns 1248.9±0.56ns +0.38%
OptimalMerkleTree::compute_root 1388.9±1.13ns 1386.4±0.89ns -0.18%
OptimalMerkleTree::delete 1384.6±1.25ns 1387.1±1.24ns +0.18%
OptimalMerkleTree::get 30.0±0.02ns 29.1±0.03ns -3.00%
OptimalMerkleTree::override_range 7.0±0.02µs 7.0±0.06µs 0.00%
OptimalMerkleTree::set 1392.0±13.47ns 1386.4±12.23ns -0.40%

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Benchmark for fa81676

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.00ns 2.0±0.00ns 0.00%
Pmtree::get 563.8±0.70ns 558.6±0.46ns -0.92%
Pmtree::override_range 210.0±11.09µs 213.3±10.83µs +1.57%
Pmtree::set 80.9±1.27µs 81.0±0.87µs +0.12%
Pmtree:delete 79.4±0.11µs 79.5±0.09µs +0.13%

@tyshko-rostyslav tyshko-rostyslav marked this pull request as ready for review September 4, 2023 10:24
rymnc
rymnc approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since all unwrap's are within the test module

@rymnc rymnc merged commit 99a5e73 into rln-v2 Sep 4, 2023
@rymnc rymnc deleted the fix-tests branch September 4, 2023 10:28
rymnc added a commit that referenced this pull request Oct 3, 2023
@rymnc @tyshko-rostyslav
feat: rln-v2 (#204)
8614b2a 
* feat(rln-v2): update serde for rln-v2 (#202)

* feat(rln-v2): update serde for rln-v2

* fix: public tests that needed to append the new fields

* s/id_commitments/rate_commitments (#205)

* feat: rename public, protocol and update tests to use rate_commitments

* fix: into()

* `message_id` range check (#210)

* feature: range check added

* fmt

* feature: message_id_range_check

* fix: corresponding change of types

* comments: function level

* fmt

* fix(rln): tests (#212)

* most changes

* fix

* fix protocol tests

* fmt

* ffi tests fix

* feat(rln-v2): new artifacts, removed older ones (#211)

* feat(rln-v2): new artifacts, removed older ones

* wip: working branch

* fix: remove more refs to epoch + rln_identifier

* Updated serde in RLN proof verification

* Updated artifacts

* chore: update

* chore: update

* hardcoded test works

* fix: proof generation and verification

* fix: rln-wasm tests

* fix: ffi tests

* fix: rln-wasm test

* fix: recover_id_secret

* Fix message (#217)



---------

Co-authored-by: rymnc <43716372+rymnc@users.noreply.github.com>

* chore: Release

---------

Co-authored-by: tyshko-rostyslav <122977916+tyshko-rostyslav@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyshko-rostyslav @rymnc