Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly build #223

Merged
merged 6 commits into from
Nov 19, 2023
Merged

Fix nightly build #223

merged 6 commits into from
Nov 19, 2023

Conversation

tyshko-rostyslav
Copy link
Contributor

@tyshko-rostyslav tyshko-rostyslav commented Nov 16, 2023

semaphore-rs has an issue on the latest commit with openssl

Copy link

Benchmark for 64caf3a

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.4±0.18ns 1.5±0.01ns -37.50%
Pmtree::get 338.4±2.40ns 334.8±3.28ns -1.06%
Pmtree::override_range 242.1±3.16µs 239.9±4.28µs -0.91%
Pmtree::set 53.1±0.48µs 53.1±0.63µs 0.00%
Pmtree:delete 53.3±0.52µs 53.3±1.17µs 0.00%

Copy link

Benchmark for 64caf3a

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 889.2±5.89ns 891.7±6.98ns +0.28%
FullMerkleTree::get 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::override_range 2.2±0.04µs 2.3±0.04µs +4.55%
FullMerkleTree::set 891.9±12.35ns 894.6±19.98ns +0.30%
OptimalMerkleTree::compute_root 1036.0±14.28ns 1037.7±29.09ns +0.16%
OptimalMerkleTree::delete 1027.7±15.48ns 1028.1±14.49ns +0.04%
OptimalMerkleTree::get 23.3±0.54ns 22.7±0.33ns -2.58%
OptimalMerkleTree::override_range 5.1±0.08µs 5.2±0.17µs +1.96%
OptimalMerkleTree::set 1025.5±3.85ns 1029.4±15.64ns +0.38%

Copy link

Benchmark for 9186db0

Click to view benchmark
Test Base PR %
Pmtree::compute_root 1.5±0.01ns 1.5±0.01ns 0.00%
Pmtree::get 329.6±2.24ns 323.9±5.56ns -1.73%
Pmtree::override_range 246.2±10.47µs 247.7±7.66µs +0.61%
Pmtree::set 53.1±0.54µs 53.1±0.40µs 0.00%
Pmtree:delete 53.1±0.64µs 53.1±0.61µs 0.00%

Copy link

Benchmark for 9186db0

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 894.4±13.10ns 891.9±12.43ns -0.28%
FullMerkleTree::get 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::override_range 2.2±0.03µs 2.2±0.05µs 0.00%
FullMerkleTree::set 897.3±49.95ns 891.1±11.66ns -0.69%
OptimalMerkleTree::compute_root 1037.4±18.29ns 1035.5±14.82ns -0.18%
OptimalMerkleTree::delete 1045.6±14.15ns 1029.7±20.32ns -1.52%
OptimalMerkleTree::get 23.2±0.34ns 22.7±0.27ns -2.16%
OptimalMerkleTree::override_range 5.2±0.24µs 5.2±0.17µs 0.00%
OptimalMerkleTree::set 1043.3±13.35ns 1035.6±52.34ns -0.74%

Copy link

Benchmark for d2ce070

Click to view benchmark
Test Base PR %
Pmtree::compute_root 1.5±0.02ns 2.5±0.02ns +66.67%
Pmtree::get 328.4±5.02ns 331.6±4.89ns +0.97%
Pmtree::override_range 244.8±2.72µs 245.1±3.60µs +0.12%
Pmtree::set 53.1±0.50µs 54.9±0.63µs +3.39%
Pmtree:delete 54.6±6.42µs 53.3±0.72µs -2.38%

Copy link

Benchmark for d2ce070

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 891.3±15.90ns 894.8±13.16ns +0.39%
FullMerkleTree::get 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::override_range 2.2±0.02µs 2.3±0.03µs +4.55%
FullMerkleTree::set 895.1±11.60ns 891.4±15.00ns -0.41%
OptimalMerkleTree::compute_root 1035.0±5.54ns 1035.2±9.88ns +0.02%
OptimalMerkleTree::delete 1025.3±6.54ns 1027.1±8.15ns +0.18%
OptimalMerkleTree::get 23.3±0.39ns 23.2±0.35ns -0.43%
OptimalMerkleTree::override_range 5.1±0.04µs 5.2±0.11µs +1.96%
OptimalMerkleTree::set 1026.3±5.41ns 1031.0±24.19ns +0.46%

Copy link

Benchmark for 686f826

Click to view benchmark
Test Base PR %
Pmtree::compute_root 1.6±0.02ns 1.5±0.01ns -6.25%
Pmtree::get 330.5±11.88ns 333.9±4.14ns +1.03%
Pmtree::override_range 243.2±5.03µs 242.0±5.03µs -0.49%
Pmtree::set 53.1±0.70µs 53.4±2.06µs +0.56%
Pmtree:delete 53.8±0.67µs 53.4±1.48µs -0.74%

Copy link

Benchmark for 686f826

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 906.7±8.11ns 894.6±10.43ns -1.33%
FullMerkleTree::get 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::override_range 2.3±0.12µs 2.2±0.02µs -4.35%
FullMerkleTree::set 902.0±8.19ns 890.3±9.00ns -1.30%
OptimalMerkleTree::compute_root 1039.6±17.04ns 1036.0±11.31ns -0.35%
OptimalMerkleTree::delete 1030.7±18.49ns 1027.7±9.89ns -0.29%
OptimalMerkleTree::get 23.1±0.33ns 23.2±0.27ns +0.43%
OptimalMerkleTree::override_range 5.2±0.08µs 5.2±0.17µs 0.00%
OptimalMerkleTree::set 1032.7±13.72ns 1031.0±18.27ns -0.16%

Copy link

Benchmark for 5a648b2

Click to view benchmark
Test Base PR %
Pmtree::compute_root 1.5±0.02ns 1.6±0.05ns +6.67%
Pmtree::get 326.1±2.73ns 325.1±4.42ns -0.31%
Pmtree::override_range 242.5±4.92µs 240.7±6.73µs -0.74%
Pmtree::set 53.1±0.64µs 53.0±0.36µs -0.19%
Pmtree:delete 53.2±0.69µs 53.2±1.01µs 0.00%

Copy link

Benchmark for 5a648b2

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 895.3±7.22ns 902.2±42.53ns +0.77%
FullMerkleTree::get 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::override_range 2.3±0.10µs 2.2±0.02µs -4.35%
FullMerkleTree::set 900.1±8.78ns 889.0±7.93ns -1.23%
OptimalMerkleTree::compute_root 1036.1±7.30ns 1035.6±7.18ns -0.05%
OptimalMerkleTree::delete 1054.2±120.88ns 1026.7±8.88ns -2.61%
OptimalMerkleTree::get 23.3±0.41ns 23.2±0.19ns -0.43%
OptimalMerkleTree::override_range 5.1±0.09µs 5.2±0.13µs +1.96%
OptimalMerkleTree::set 1028.6±19.63ns 1030.1±20.18ns +0.15%

@tyshko-rostyslav tyshko-rostyslav marked this pull request as ready for review November 16, 2023 12:10
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rymnc rymnc merged commit b576069 into master Nov 19, 2023
23 checks passed
@rymnc rymnc deleted the nightly_build_fix branch November 19, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants