Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rln) : Update documentation for rln-v2 to include new serde format #245

Merged
merged 2 commits into from
May 10, 2024

Conversation

seemenkina
Copy link
Contributor

Part of #237

@seemenkina seemenkina requested a review from rymnc May 10, 2024 07:18
@seemenkina seemenkina self-assigned this May 10, 2024
@seemenkina seemenkina marked this pull request as ready for review May 10, 2024 07:18
Copy link

Benchmark for e1e08b2

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 912.8±33.26ns 889.5±13.40ns -2.55%
FullMerkleTree::get 3.5±0.05ns 3.4±0.08ns -2.86%
FullMerkleTree::override_range 2.2±0.01µs 2.2±0.03µs 0.00%
FullMerkleTree::set 900.9±12.18ns 888.0±13.22ns -1.43%
OptimalMerkleTree::compute_root 1042.1±13.88ns 1031.5±12.90ns -1.02%
OptimalMerkleTree::delete 1033.7±17.59ns 1026.7±5.85ns -0.68%
OptimalMerkleTree::get 23.5±0.31ns 23.5±0.29ns 0.00%
OptimalMerkleTree::override_range 5.2±0.07µs 5.2±0.17µs 0.00%
OptimalMerkleTree::set 1036.3±8.46ns 1037.4±25.60ns +0.11%

Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great stuff

can you add a sub-task to the v0.5.0 release issue which removes the resources_folder from the rln config?

/// Example:
/// ```
/// use std::io::Cursor;
///
/// let tree_height = 20;
/// let resources = Cursor::new(json!({"resources_folder": "tree_height_20"});
Copy link
Contributor

@rymnc rymnc May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, should we probably remove this as a config parameter (non-blocking, should be in another PR)? resources_folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, I guess if the data from our directory is always be used, then yes

Copy link

Benchmark for e1e08b2

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 13.7±0.11ms 14.3±0.09ms +4.38%
OptimalMerkleTree::::full_height_gen 554.6±5.86µs 551.5±13.22µs -0.56%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 359.3±3.48ns 318.8±4.62ns -11.27%
Pmtree::override_range 236.0±6.24µs 241.7±5.26µs +2.42%
Pmtree::set 54.3±0.43µs 54.3±0.58µs 0.00%
Pmtree:delete 54.4±0.37µs 54.2±0.32µs -0.37%
Set/FullMerkleTree::::set/1 553.0±6.81µs 559.8±2.58µs +1.23%
Set/FullMerkleTree::::set/10 5.6±0.02ms 5.6±0.03ms 0.00%
Set/FullMerkleTree::::set/100 55.9±0.09ms 55.9±0.24ms 0.00%
Set/FullMerkleTree::::set_range/1 556.6±5.12µs 560.3±6.20µs +0.66%
Set/FullMerkleTree::::set_range/10 756.9±3.84µs 759.7±7.85µs +0.37%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.01ms 0.00%
Set/OptimalMerkleTree::::set/1 552.5±5.88µs 551.3±3.90µs -0.22%
Set/OptimalMerkleTree::::set/10 5.6±0.03ms 5.6±0.02ms 0.00%
Set/OptimalMerkleTree::::set/100 55.8±0.22ms 55.8±0.22ms 0.00%
Set/OptimalMerkleTree::::set_range/1 551.7±3.05µs 553.1±7.53µs +0.25%
Set/OptimalMerkleTree::::set_range/10 5.6±0.01ms 5.6±0.02ms 0.00%
Set/OptimalMerkleTree::::set_range/100 55.6±0.57ms 55.7±0.20ms +0.18%
zkey::upload_from_folder 3.3±0.00s 3.3±0.00s 0.00%

Copy link

Benchmark for 82fa183

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 885.0±5.74ns 883.9±7.19ns -0.12%
FullMerkleTree::get 3.5±0.04ns 3.5±0.07ns 0.00%
FullMerkleTree::override_range 2.2±0.08µs 2.2±0.03µs 0.00%
FullMerkleTree::set 886.0±15.44ns 886.5±7.09ns +0.06%
OptimalMerkleTree::compute_root 1056.0±12.09ns 1038.3±14.03ns -1.68%
OptimalMerkleTree::delete 1045.6±8.21ns 1033.0±14.72ns -1.21%
OptimalMerkleTree::get 24.1±2.61ns 23.5±0.31ns -2.49%
OptimalMerkleTree::override_range 5.3±0.04µs 5.3±0.30µs 0.00%
OptimalMerkleTree::set 1050.5±31.19ns 1037.7±22.30ns -1.22%

Copy link

Benchmark for 82fa183

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 15.7±0.34ms 15.1±0.39ms -3.82%
OptimalMerkleTree::::full_height_gen 553.8±6.72µs 566.2±40.28µs +2.24%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 317.8±2.80ns 318.7±3.85ns +0.28%
Pmtree::override_range 231.5±3.40µs 233.0±3.80µs +0.65%
Pmtree::set 54.5±1.08µs 54.2±0.70µs -0.55%
Pmtree:delete 54.3±0.71µs 54.4±0.74µs +0.18%
Set/FullMerkleTree::::set/1 551.2±4.69µs 551.3±3.57µs +0.02%
Set/FullMerkleTree::::set/10 5.5±0.01ms 5.6±0.03ms +1.82%
Set/FullMerkleTree::::set/100 55.7±0.71ms 55.7±0.21ms 0.00%
Set/FullMerkleTree::::set_range/1 552.2±4.85µs 550.6±3.64µs -0.29%
Set/FullMerkleTree::::set_range/10 758.0±4.81µs 759.1±8.67µs +0.15%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.00ms 0.00%
Set/OptimalMerkleTree::::set/1 552.1±5.86µs 569.7±7.39µs +3.19%
Set/OptimalMerkleTree::::set/10 5.5±0.01ms 5.6±0.02ms +1.82%
Set/OptimalMerkleTree::::set/100 55.5±0.09ms 56.1±0.45ms +1.08%
Set/OptimalMerkleTree::::set_range/1 551.4±6.22µs 554.2±7.14µs +0.51%
Set/OptimalMerkleTree::::set_range/10 5.6±0.02ms 5.6±0.03ms 0.00%
Set/OptimalMerkleTree::::set_range/100 55.9±2.38ms 56.4±0.15ms +0.89%
zkey::upload_from_folder 3.3±0.01s 3.3±0.00s 0.00%

@seemenkina seemenkina merged commit 652cc36 into master May 10, 2024
10 checks passed
@seemenkina seemenkina deleted the doc-update branch May 10, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants