-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rln) : Update documentation for rln-v2 to include new serde format #245
Conversation
Benchmark for e1e08b2Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great stuff
can you add a sub-task to the v0.5.0 release issue which removes the resources_folder
from the rln config?
/// Example: | ||
/// ``` | ||
/// use std::io::Cursor; | ||
/// | ||
/// let tree_height = 20; | ||
/// let resources = Cursor::new(json!({"resources_folder": "tree_height_20"}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, should we probably remove this as a config parameter (non-blocking, should be in another PR)? resources_folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, I guess if the data from our directory is always be used, then yes
Benchmark for e1e08b2Click to view benchmark
|
Benchmark for 82fa183Click to view benchmark
|
Benchmark for 82fa183Click to view benchmark
|
Part of #237