Allow multiple change outputs #1025
Conversation
PeterBenc
force-pushed
the
allow-multiple-change-outputs
branch
from
0311bc5 to
409e956
Compare
PeterBenc
force-pushed
the
allow-multiple-change-outputs
branch
from
e47f4df to
d95bebe
Compare
| minimalLovelaceAmount: additionalLovelaceAmount, | ||
| } | ||
|
|
||
| const outputsWithChange = change ? [...outputs, ...change] : outputs |
There was a problem hiding this comment.
empty array is truthy in JS, so I believe this actually always ends up in the left branch, or can the "change" be null? In that case I'd rather be more explicit and check for change != null
There was a problem hiding this comment.
I totally missed this, thanks, will fix 👍
| // max token size about 70 bytes, max output size is 4000 => 4000 / 70 ~ 50 | ||
| export const MAX_OUTPUT_TOKENS = 50 | ||
|
|
||
| export const MIN_UTXO_VALUE = 1000000 |
There was a problem hiding this comment.
Isn't this rather ADA_ONLY_MIN_UTXO_VALUE ?
| const totalOutput = outputs.reduce((acc, {coins}) => acc + coins, 0) + deposit | ||
| const totalOutputTokens = aggregateTokenBundles(outputs.map(({tokenBundle}) => tokenBundle)) | ||
|
|
||
| // total amount of lovelace that had to be added to token-containing outputs |
There was a problem hiding this comment.
perhaps a single bigger multiline comment at the beginning outlining the steps in human language here would help a lot in figuring out what's going on. The one-line comments scattered around the code help to some extent, but it's already too hard to get a bigger picture out of them - could you write such comment @PeterBenc ?
Refactor tx planning - create adaOnly change output
PeterBenc
force-pushed
the
allow-multiple-change-outputs
branch
from
4b566b7 to
1cae13c
Compare
Changes:
Gotcha: