Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple address parameters validation from address derivation #59

Closed
gabrielKerekes opened this issue Apr 11, 2021 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@gabrielKerekes
Copy link
Collaborator

In general we try to follow the pattern of first validating incoming data and then doing the actual work with them. When it comes to address derivation from address parameters we do the validation as part of derive_address_bytes. E.g. in sign_tx._validate_outputs we use derive_address_bytes to validate the outputs' address parameters instead of having a separate function for validation.

This became apparent when catalyst registration seemed to be lacking address validation, because it's hidden in derive_address_bytes - #57 (comment)

Actionables:

  1. investigate whether address parameters valdiation can be nicely separated overall
  2. separate address parameters validation from address derivation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant