You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In general we try to follow the pattern of first validating incoming data and then doing the actual work with them. When it comes to address derivation from address parameters we do the validation as part of derive_address_bytes. E.g. in sign_tx._validate_outputs we use derive_address_bytes to validate the outputs' address parameters instead of having a separate function for validation.
This became apparent when catalyst registration seemed to be lacking address validation, because it's hidden in derive_address_bytes - #57 (comment)
Actionables:
investigate whether address parameters valdiation can be nicely separated overall
separate address parameters validation from address derivation
The text was updated successfully, but these errors were encountered:
In general we try to follow the pattern of first validating incoming data and then doing the actual work with them. When it comes to address derivation from address parameters we do the validation as part of
derive_address_bytes
. E.g. insign_tx._validate_outputs
we usederive_address_bytes
to validate the outputs' address parameters instead of having a separate function for validation.This became apparent when catalyst registration seemed to be lacking address validation, because it's hidden in
derive_address_bytes
- #57 (comment)Actionables:
The text was updated successfully, but these errors were encountered: