-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cardano small updates #1606
Cardano small updates #1606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice
one point about typing annotations, otherwise LGTM
also please add a changelog per https://docs.trezor.io/trezor-firmware/misc/changelog.html |
it seems some of your address test vectors are wrong now: https://gitlab.com/satoshilabs/trezor/trezor-firmware/-/jobs/1318118622 |
Changelogs added - 0010bbc. I am not sure if two entries are desirable or just one would be enough similar to
Indeed. Luckily nothing got broken, it really was just an invalid test vector. Fixed in 7c573c9. |
these entries seem appropriate 👍 in the meantime we changed import paths so you got some conflicts, please squash the fixups and rebase on top of master |
for messages, instead of |
Output size is currently limited to 4000 bytes at protocol level. Given the maximum transaction size Trezor can handle (~9kB), we also want to enforce this size limit here so that when the limit is raised at protocol level again, Trezor would still not be able to produce larger outputs than it could reliably spend. Once Cardano-transaction signing is refactored to be completely streamed and maximum supported transaction size is thus raised, this limit can be lifted.
0010bbc
to
38844ee
Compare
Done. |
and done, thanks! |
This PR contains small refactorings and updates for the Cardano app.
address
andaddress_parameters
- previously if both were set were setaddress
would simply be ignored andaddress_parameters
would be used