Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards compatibility for positional args #33

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

karaggeorge
Copy link
Collaborator

Fixes #32

Adds backwards compatibility for clis that were built with a previous version but are being ran using v1.1.0

I tried to find other backwards compatibility issues, but I don't think there is any other than positional args. That was the only thing added to the commands.json structure.

Will need another release with those changes

Copy link

@adam-lynch adam-lynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue. Thanks @karaggeorge 👍

@karaggeorge
Copy link
Collaborator Author

Glad to hear that @adam-lynch

@vadimdemedes I just pushed a commit to fix the failing test/edge case, but I think this should be good to go

@vadimdemedes
Copy link
Owner

Thanks @karaggeorge!

@vadimdemedes
Copy link
Owner

@karaggeorge Would you be interested to be added as a maintainer of Pastel? Totally cool if not :)

@vadimdemedes vadimdemedes merged commit 3daf602 into vadimdemedes:master Aug 12, 2020
@karaggeorge
Copy link
Collaborator Author

@vadimdemedes Yeah, I'd be glad to 😄 If you have any ideas for features let me know. I'm still trying to find a way to incorporate arg types from type definitions

@vadimdemedes
Copy link
Owner

Awesome! Yeah, I think we should get rid of prop types in favor of TypeScript types, it makes way more sense.

@karaggeorge
Copy link
Collaborator Author

Wouldn't that force people to use TypeScript? I think keeping propTypes as a fallback is fine

@vadimdemedes
Copy link
Owner

Yep, although I'm not sure it's that big of a trade-off, most folks use TypeScript nowadays either way. I think this limitation could greatly simplify the maintenance of Pastel. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

positional argument value is undefined in v1.1.0
3 participants